Move typo checks to after_insert
#17764
Open
+96
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
reviewed
Mar 13, 2025
| @@ -496,6 +502,92 @@ def yanked_releases(self): | |||
| ) | |||
|
|
|||
|
|
|||
| @event.listens_for(Project, "after_insert") | |||
There was a problem hiding this comment.
In other places we use our own @db.listens_for(db.Session, ... - any reason to not use that?
| @@ -496,6 +502,92 @@ def yanked_releases(self): | |||
| ) | |||
|
|
|||
|
|
|||
| @event.listens_for(Project, "after_insert") | |||
There was a problem hiding this comment.
This is the first time after_insert is used in warehouse - looking at the docs, it's clarifying that this happens after session flush, not as part of the ORM Insert approach.
How did you validate the notification is still sent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Marking as draft since this still needs tests).This is a proof-of-concept to show that we can move the non-blocking project name typo checks to an
after_insertmapper event hook, in order to avoid duplicate notifications if project creation is attempted but ends up failing due to various checks.